Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes home-assistant/core#103208
Supersedes #166
The S2C modules do support energy scan:
https://www.digi.com/resources/documentation/digidocs/90002002/default.htm#Reference/r_cmd_ED.htm?TocPath=AT%2520commands%257CNetwork%2520commands%257C_____17
The difference with XBee3 is the parameter range: S2C accepts 0x01-0xFF or no parameter, while XBee3 accepts 0x00-0xFF. In other words, to use a default parameter value one need to pass no parameters for S2C and 0x00 for XBee3.
Due to a bug we are sending the parameter as
b'\x00\x00\x00\x00'
instead ofb'\x04'
for 4 ms, the XBee3 firmware accepts that parameter as default, while S2C firmware returns anINVALD_PARAMETER
response.The bug is because we implicitly used
bytes()
constructor with an integer argument, that returns an array of zeros. Using[duration_exp]
orbytes([duration_exp])
instead ofduration_exp
resolves the issue.